Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conditional canceling bolusState for bolusTrigger false call #369

Conversation

kskandis
Copy link
Contributor

Removed canceling conditional per discord conversation

mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Aug 1, 2024
Remove trailing slash from NS URL
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @itsmojo on Discord, removed unnecessary condition that was introduced with the OmniXXX fixes.

LGTM.

@bjornoleh
Copy link
Contributor

Merging with two approvals

@bjornoleh bjornoleh merged commit c04d33e into nightscout:dev Aug 12, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request Aug 17, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Sep 11, 2024
…tusCalls-bolusTriggerCancelingState

remove conditional canceling bolusState for bolusTrigger false call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants